Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add warm starting #1389

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add warm starting #1389

wants to merge 3 commits into from

Conversation

fallenatlas
Copy link
Contributor

@fallenatlas fallenatlas commented Nov 25, 2024 •
edited
Loading

Description

Add warm starting to physics. Takes the impulses applied in the previous frame to apply them at the beggining of the next for increased stability in stacking scenarios.

Checklist

  • Self-review changes.
  • Evaluate impact on the documentation.
  • Add entry to the changelog's unreleased section.

@fallenatlas fallenatlas added this to the 0.6 milestone Nov 25, 2024
@fallenatlas fallenatlas self-assigned this Nov 25, 2024
@fallenatlas fallenatlas linked an issue Nov 25, 2024 that may be closed by this pull request
Implement Warm starting #1248
Open
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 25, 2024 •
edited
Loading

PR Preview Action v1.6.0

🚀 View preview at
https://GameDevTecnico.github.io/cubos/preview/pr-1389/

Built to branch gh-pages at 2025-01-22 14:31 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

github-actions[bot]
github-actions bot reviewed Nov 25, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Clang-Tidy found issue(s) with the introduced code (1/1)

engine/src/physics/solver/penetration_constraint/plugin.cpp Show resolved Hide resolved
engine/src/physics/solver/penetration_constraint/plugin.cpp Show resolved Hide resolved
engine/src/physics/solver/penetration_constraint/plugin.cpp Show resolved Hide resolved
engine/src/physics/solver/penetration_constraint/plugin.cpp Outdated Show resolved Hide resolved
engine/src/physics/solver/penetration_constraint/plugin.cpp Show resolved Hide resolved
engine/src/physics/solver/penetration_constraint/plugin.cpp Show resolved Hide resolved
engine/src/physics/solver/penetration_constraint/plugin.cpp Show resolved Hide resolved
@fallenatlas fallenatlas force-pushed the 1248-implement-warm-starting branch from 3032871 to 12e15c3 Compare January 22, 2025 14:28
@github-actions github-actions bot added the P-Urgent This issue is a big priority, and it would be good to close it ASAP label Jan 22, 2025
@fallenatlas fallenatlas force-pushed the 1248-implement-warm-starting branch from 12e15c3 to 40946bb Compare January 22, 2025 14:39
@fallenatlas fallenatlas force-pushed the 1248-implement-warm-starting branch from 40946bb to 85c54d8 Compare January 22, 2025 14:59
@fallenatlas fallenatlas marked this pull request as ready for review January 22, 2025 18:23
@fallenatlas fallenatlas requested review from RiscadoA and a team as code owners January 22, 2025 18:23
@fallenatlas fallenatlas requested review from joaomanita, GCeSilva and diogomsmiranda and removed request for a team January 22, 2025 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@joaomanita joaomanita joaomanita approved these changes

@RiscadoA RiscadoA Awaiting requested review from RiscadoA RiscadoA is a code owner

@GCeSilva GCeSilva Awaiting requested review from GCeSilva GCeSilva is a code owner automatically assigned from GameDevTecnico/cubos-physics-team

@diogomsmiranda diogomsmiranda Awaiting requested review from diogomsmiranda diogomsmiranda is a code owner automatically assigned from GameDevTecnico/cubos-wildcard-team

At least 3 approving reviews are required to merge this pull request.

Assignees

@fallenatlas fallenatlas

Labels
A-Engine B-Physics P-Urgent This issue is a big priority, and it would be good to close it ASAP
Projects
None yet
Milestone
0.6
Development

Successfully merging this pull request may close these issues.

Implement Warm starting
2 participants
@fallenatlas @joaomanita